Bug 257437

Summary: Remove redundant RenderTextControl::textBlockLogicalWidth
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, mmaxfield, ntim, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2023-05-27 21:36:53 PDT
ssia
Attachments
Patch (4.42 KB, patch)
2023-05-27 21:38 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2023-05-27 21:40 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-05-27 21:38:26 PDT
Created attachment 466522 [details] Patch
alan
Comment 2 2023-05-27 21:40:05 PDT
Created attachment 466523 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2023-05-28 09:58:34 PDT
Comment on attachment 466523 [details] Patch LGTM
Tim Nguyen (:ntim)
Comment 4 2023-05-28 10:01:02 PDT
Comment on attachment 466523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466523&action=review > Source/WebCore/rendering/RenderTextControl.cpp:-91 > -int RenderTextControl::textBlockLogicalHeight() const > -{ > - return logicalHeight() - borderAndPaddingLogicalHeight(); > -} > - > -int RenderTextControl::textBlockLogicalWidth() const Please remove from header file as well.
alan
Comment 5 2023-05-28 18:29:21 PDT
(In reply to Tim Nguyen (:ntim) from comment #4) > Comment on attachment 466523 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466523&action=review > > > Source/WebCore/rendering/RenderTextControl.cpp:-91 > > -int RenderTextControl::textBlockLogicalHeight() const > > -{ > > - return logicalHeight() - borderAndPaddingLogicalHeight(); > > -} > > - > > -int RenderTextControl::textBlockLogicalWidth() const > > Please remove from header file as well. I did, didn't I?
alan
Comment 6 2023-05-28 18:29:56 PDT
(In reply to Tim Nguyen (:ntim) from comment #3) > Comment on attachment 466523 [details] > Patch > > LGTM Thank you.
EWS
Comment 7 2023-05-28 19:17:50 PDT
Committed 264645@main (400b4102ecf3): <https://commits.webkit.org/264645@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466523 [details].
Radar WebKit Bug Importer
Comment 8 2023-05-28 19:18:17 PDT
<rdar://problem/109957291>
Note You need to log in before you can comment on or make changes to this bug.