| Summary: | Remove redundant RenderTextControl::textBlockLogicalWidth | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, mmaxfield, ntim, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-05-27 21:36:53 PDT
Created attachment 466522 [details]
Patch
Created attachment 466523 [details]
Patch
Comment on attachment 466523 [details]
Patch
LGTM
Comment on attachment 466523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466523&action=review > Source/WebCore/rendering/RenderTextControl.cpp:-91 > -int RenderTextControl::textBlockLogicalHeight() const > -{ > - return logicalHeight() - borderAndPaddingLogicalHeight(); > -} > - > -int RenderTextControl::textBlockLogicalWidth() const Please remove from header file as well. (In reply to Tim Nguyen (:ntim) from comment #4) > Comment on attachment 466523 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466523&action=review > > > Source/WebCore/rendering/RenderTextControl.cpp:-91 > > -int RenderTextControl::textBlockLogicalHeight() const > > -{ > > - return logicalHeight() - borderAndPaddingLogicalHeight(); > > -} > > - > > -int RenderTextControl::textBlockLogicalWidth() const > > Please remove from header file as well. I did, didn't I? (In reply to Tim Nguyen (:ntim) from comment #3) > Comment on attachment 466523 [details] > Patch > > LGTM Thank you. Committed 264645@main (400b4102ecf3): <https://commits.webkit.org/264645@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466523 [details]. |