Bug 257443

Summary: RemoteLayerTreeDisplayRefreshMonitor::displayNominalFramesPerSecond returns the preferred frames per second
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: Layout and RenderingAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Matt Woodrow
Reported 2023-05-28 14:56:38 PDT
displayNominalFramesPerSecond is intended to return the refresh rate of the display, but RemoteLayerTreeDisplayRefreshMonitor returns the preferred value set by the Page. This might be the nominal rate, but could also be a lower value if the Page applied throttling. The only caller of this function is Page, so it's a circular dependency, that can't return any useful information. I'm not aware of current bugs from this, but it seems plausible that we'd issue a windowScreenDidChange on iOS, and retrieve a throttled rate from the existing refresh monitor.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-05-28 14:57:19 PDT
Matt Woodrow
Comment 2 2023-05-28 15:08:15 PDT
EWS
Comment 3 2023-05-31 22:20:32 PDT
Committed 264775@main (e85bed10ffa8): <https://commits.webkit.org/264775@main> Reviewed commits have been landed. Closing PR #14444 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.