Bug 257474

Summary:	[JSC] Implement isNaN / Number.isNaN in C++
Product:	WebKit	Reporter:	Yusuke Suzuki <ysuzuki>
Component:	JavaScriptCore	Assignee:	Yusuke Suzuki <ysuzuki>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=258592
Bug Depends on:	257541
Bug Blocks:

Description Yusuke Suzuki 2023-05-30 02:52:55 PDT

...

Comment 1 Radar WebKit Bug Importer 2023-05-30 02:53:08 PDT

<rdar://problem/109996676>

Comment 2 Yusuke Suzuki 2023-05-30 02:54:08 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14473

Comment 3 EWS 2023-05-30 13:54:27 PDT

Committed 264697@main (5d3b2384ab2b): <https://commits.webkit.org/264697@main>

Reviewed commits have been landed. Closing PR #14473 and removing active labels.

Comment 4 WebKit Commit Bot 2023-05-31 08:38:09 PDT

Re-opened since this is blocked by bug 257541

Comment 5 Alexey Proskuryakov 2023-05-31 08:41:17 PDT

This caused many assertion failures, reverting. E.g. https://build.webkit.org/results/Apple-Ventura-Debug-AppleSilicon-WK1-Tests/264701@main%20(2423)/results.html

DFG ASSERTION FAILED: AI-clobberize disagreement; AI says ClobberedStructures while clobberize says (Direct:[], Super:[])
./dfg/DFGCFAPhase.cpp(240) : void JSC::DFG::CFAPhase::performBlockCFA(JSC::DFG::BasicBlock *)

Comment 6 Yusuke Suzuki 2023-05-31 09:09:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14538

Comment 7 EWS 2023-05-31 17:45:32 PDT

Committed 264768@main (c602f3ac3760): <https://commits.webkit.org/264768@main>

Reviewed commits have been landed. Closing PR #14538 and removing active labels.