Bug 257485

Summary:	REGRESSION(262844@main): svg/dynamic-updates/SVGFE* tests no longer react on changes
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	SVG	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, heycam, sabouhallawa, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255258

Description Nikolas Zimmermann 2023-05-30 07:44:23 PDT

Back in February, svg/dynamic-updates/SVGFE* tests were still working properly - in ToT they no longer show any visual update. Investigate.
Mark them as 'ImageOnlyFailure' in the test expectations for now.

As said before, these tests should really be reftests -- we cannot detect these kind of issues in EWS & co, since these tests all rely on pixel testing, which is not run by default on the bots.

Comment 1 Nikolas Zimmermann 2023-05-30 07:56:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14482

Comment 2 EWS 2023-05-30 07:58:28 PDT

Committed 264674@main (03d330e0fe9b): <https://commits.webkit.org/264674@main>

Reviewed commits have been landed. Closing PR #14482 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-05-30 07:59:15 PDT

<rdar://problem/110005491>

Comment 4 Nikolas Zimmermann 2023-05-30 08:06:51 PDT

They were only marked as failures in the expectations -- the bug is not fixed yet, reopening.

Comment 5 Cameron McCormack (:heycam) 2023-05-31 00:24:00 PDT

Caused by https://bugs.webkit.org/show_bug.cgi?id=255258.

Comment 6 Chris Dumez 2023-05-31 08:56:51 PDT

I caused this, I can investigate and fix.

Comment 7 Chris Dumez 2023-05-31 09:52:07 PDT

I have been opening a few of these tests in the browser with a spade before my change and trunk and don't see much difference. How can I tell the tests are failing?

Comment 8 Chris Dumez 2023-05-31 09:59:00 PDT

Maybe not all the tests that were skipped are truly failing. I found LayoutTests/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html that is definitely failing though.

Comment 9 Chris Dumez 2023-05-31 13:02:23 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14550

Comment 10 EWS 2023-05-31 16:14:58 PDT

Committed 264763@main (d91dd403c67e): <https://commits.webkit.org/264763@main>

Reviewed commits have been landed. Closing PR #14550 and removing active labels.