Bug 257650

Summary:	Move WebCore::RunLoopObserver from WebCore/platform/cf to WebCore/platform
Product:	WebKit	Reporter:	Wenson Hsieh <wenson_hsieh>
Component:	Platform	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dpino, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	257622

Description Wenson Hsieh 2023-06-02 09:12:16 PDT

...so that we can use it in (otherwise) platform-agnostic code.

For now, this will only have a concrete implementation when `USE(CF)` is defined, but we could make it work with other ports (e.g. `GLIB_EVENT_LOOP` / `WINDOWS_EVENT_LOOP`) as well, in a followup.

Comment 1 Wenson Hsieh 2023-06-02 09:27:53 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14630

Comment 2 Radar WebKit Bug Importer 2023-06-09 09:13:17 PDT

<rdar://problem/110531974>

Comment 3 EWS 2023-06-12 14:19:08 PDT

Committed 265089@main (a1236fc76789): <https://commits.webkit.org/265089@main>

Reviewed commits have been landed. Closing PR #14630 and removing active labels.

Comment 4 Diego Pino 2023-06-12 23:08:19 PDT

WebKitGTK Release post-commit build bot is failing after this patch landed:

https://build.webkit.org/#/builders/41/builds/19615/steps/10/logs/stdio

from /app/webkit/Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp:21,
from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-51.cpp:1:
/app/webkit/Source/WebCore/platform/VideoEncoderActiveConfiguration.h:35:12: error: field ‘codec’ has incomplete type ‘WTF::String’
   35 |     String codec;
      |            ^~~~~

It's a non-unified sources build error, `#include <WTFString.h>` is missing.

Comment 5 Diego Pino 2023-06-12 23:08:59 PDT

Re-opening for pull request https://github.com/webkit/webkit/pull/14907

Comment 6 EWS 2023-06-12 23:17:34 PDT

Committed 265105@main (90873fe270bf): <https://commits.webkit.org/265105@main>

Reviewed commits have been landed. Closing PR #14907 and removing active labels.