Bug 257680

Summary: [IFC] Rename LineBuilder::LineContent to LineLayoutResult
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

Description zalan 2023-06-03 14:16:37 PDT
ssia
Comment 1 zalan 2023-06-03 14:22:27 PDT
Created attachment 466579 [details]
Patch
Comment 2 zalan 2023-06-03 15:17:49 PDT
Created attachment 466580 [details]
Patch
Comment 3 zalan 2023-06-03 21:28:46 PDT
Created attachment 466584 [details]
Patch
Comment 4 Antti Koivisto 2023-06-05 01:52:33 PDT
Comment on attachment 466584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466584&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:52
> +    struct LineLayoutResult {

I suppose "Line" is slightly redundant here since this is scoped to LineBuilder.
Comment 5 zalan 2023-06-05 06:11:29 PDT
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 466584 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466584&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:52
> > +    struct LineLayoutResult {
> 
> I suppose "Line" is slightly redundant here since this is scoped to
> LineBuilder.
Good point!
Comment 6 zalan 2023-06-05 06:17:12 PDT
Created attachment 466592 [details]
[fast-cq]Patch
Comment 7 EWS 2023-06-05 08:48:42 PDT
Committed 264869@main (450b4ccb7fd0): <https://commits.webkit.org/264869@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466592 [details].
Comment 8 Radar WebKit Bug Importer 2023-06-05 08:49:23 PDT
<rdar://problem/110264479>