Bug 257705

Summary:	[Curl] Proxy authentication during CONNECT request is not working after 256639@main.
Product:	WebKit	Reporter:	Kenji Shukuwa <kenji.shukuwa>
Component:	Platform	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Kenji Shukuwa 2023-06-05 01:04:04 PDT

Proxy authentication does not work after 256639@main. 

If CURLINFO_HTTP_CONNECTCODE is 407, invokeDidReceiveResponse() should be called to handle
proxy authentication (NetworkDataTaskCurl::tryProxyAuthentication).

---
CurlRequest::didCompleteTransfer() ==>
CurlRequest::invokeDidReceiveResponse() ==>
NetworkDataTaskCurl::curlDidReceiveResponse() ==>
NetworkDataTaskCurl::tryProxyAuthentication()
---

Comment 1 Kenji Shukuwa 2023-06-05 01:16:46 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14664

Comment 2 Kenji Shukuwa 2023-06-05 06:38:19 PDT

Comment 0 was not an accurate description. Correctly, proxy authentication for CONNECT requests is no longer working.

If you get a proxy authentication (407) response after sending a CONNECT request to the proxy server, Proxy authentication processing was performed before 256639@main, but an error occurs after 256639@main.

Major browsers handle proxy authentication responses to CONNECT requests. So, fix it so that the curl port can also perform proxy authentication.

Comment 3 EWS 2023-06-05 13:57:10 PDT

Committed 264874@main (be820d76b164): <https://commits.webkit.org/264874@main>

Reviewed commits have been landed. Closing PR #14664 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-06-05 13:58:17 PDT

<rdar://problem/110275130>

Comment 5 Fujii Hironori 2023-06-05 14:03:01 PDT

Playwright issue: https://github.com/microsoft/playwright/issues/22184