Bug 257717

Summary:	Resolutions in calc should always be serialized to dppx
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cyb.ai.815, karlcow, rreno, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Tim Nguyen (:ntim) 2023-06-05 09:15:17 PDT

The canonical unit for resolution is dppx, we should always convert resolutions to use that unit.

See failures at: https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat

Comment 1 Radar WebKit Bug Importer 2023-06-05 09:15:27 PDT

<rdar://problem/110265669>

Comment 2 Cheng You Bai (:cybai) 2023-06-21 23:59:02 PDT

I also noticed the failures in https://wpt.fyi/results/css/mediaqueries/match-media-parsing.html?label=experimental&label=master&aligned related to this issue. May I work on this one?

Comment 3 Ryan Reno 2023-06-22 11:49:10 PDT

(In reply to Cheng You Bai (:cybai) from comment #2)
> I also noticed the failures in
> https://wpt.fyi/results/css/mediaqueries/match-media-parsing.
> html?label=experimental&label=master&aligned related to this issue. May I
> work on this one?

Please do, thanks!

Comment 4 Cheng You Bai (:cybai) 2023-06-22 23:28:54 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15229

Comment 5 EWS 2023-06-23 11:39:10 PDT

Committed 265469@main (a4c5bcd2ebf9): <https://commits.webkit.org/265469@main>

Reviewed commits have been landed. Closing PR #15229 and removing active labels.