Bug 257717
| Summary: | Resolutions in calc should always be serialized to dppx | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cyb.ai.815, karlcow, rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
The canonical unit for resolution is dppx, we should always convert resolutions to use that unit.
See failures at: https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110265669>
Cheng You Bai (:cybai)
I also noticed the failures in https://wpt.fyi/results/css/mediaqueries/match-media-parsing.html?label=experimental&label=master&aligned related to this issue. May I work on this one?
Ryan Reno
(In reply to Cheng You Bai (:cybai) from comment #2)
> I also noticed the failures in
> https://wpt.fyi/results/css/mediaqueries/match-media-parsing.
> html?label=experimental&label=master&aligned related to this issue. May I
> work on this one?
Please do, thanks!
Cheng You Bai (:cybai)
Pull request: https://github.com/WebKit/WebKit/pull/15229
EWS
Committed 265469@main (a4c5bcd2ebf9): <https://commits.webkit.org/265469@main>
Reviewed commits have been landed. Closing PR #15229 and removing active labels.