Bug 25782

Summary: Allow custom memory allocation control in JavaScriptCore
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch for HashTable
mjs: review+
proposed patch for HashTable struct
none
proposed patch for HashTable struct darin: review+

Zoltan Horvath
Reported 2009-05-14 02:01:21 PDT
FastAllocBase class landed in the trunk (bug #20422) at r42344. Now we have to continue the work with inherite some classes from it. TODOs: - We have to inherit every classes from FastAllocBase which has been instantiated by 'new'. - We have to put FastAllocBase into inheritance tree as far up as possible. First I file a patch for one class called HashTable. After it'll be in the trunk I'll file a list which classes instantiated by 'new'.
Attachments
proposed patch for HashTable (1.38 KB, patch)
2009-05-14 02:02 PDT, Zoltan Horvath 		mjs: review+
DetailsFormatted DiffDiff
proposed patch for HashTable struct (3.98 KB, patch)
2009-06-02 06:16 PDT, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
proposed patch for HashTable struct (deleted)
2009-06-02 10:23 PDT, Zoltan Horvath 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-05-14 02:02:18 PDT
Created attachment 30319 [details] proposed patch for HashTable
Maciej Stachowiak
Comment 2 2009-05-22 01:18:47 PDT
Comment on attachment 30319 [details] proposed patch for HashTable r=me
Brent Fulgham
Comment 3 2009-05-26 15:28:04 PDT
Landed in @r44161.
Zoltan Horvath
Comment 4 2009-06-02 06:15:17 PDT
I've analysed the source and noticed that I inherited the wrong HashTable class. Sorry, I've filed a new patch which contains the correction of the mistake and the allocation support for the 'real' HashTable. Details in the patch.
Zoltan Horvath
Comment 5 2009-06-02 06:16:12 PDT
Created attachment 30868 [details] proposed patch for HashTable struct
Zoltan Horvath
Comment 6 2009-06-02 09:20:40 PDT
Simplier method is to change 'new' call to fastNew, and 'delete' to fastDelete. (In this case I need to modify only where HashTable instantiated by 'new' and destructed with delete. JSGlobalData.cpp:106-112) If you wish I could attach a patch with this solution.
Zoltan Horvath
Comment 7 2009-06-02 10:23:56 PDT
Created attachment 30871 [details] proposed patch for HashTable struct Based on Darin's https://bugs.webkit.org/show_bug.cgi?id=20422#c36 comment, I filed the fastNew/fastDelete solution.
Darin Adler
Comment 8 2009-06-02 12:25:02 PDT
Comment on attachment 30871 [details] proposed patch for HashTable struct r=me
Brent Fulgham
Comment 9 2009-06-03 15:50:50 PDT
Assign for landing.
Brent Fulgham
Comment 10 2009-06-04 10:30:57 PDT
Landed in @r44417.
Note You need to log in before you can comment on or make changes to this bug.