Bug 257938

Summary:	Use smart pointers with PageLoadStateObserverBase subclasses and instance variables
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	WebKit Process Model	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	258051

David Kilzer (:ddkilzer)

Reported 2023-06-10 11:47:20 PDT

Use smart pointers with PageLoadStateObserverBase subclasses and instance variables. NavigationState inherits from CanMakeWeakPtr<>, but PageLoadStateObserver should also use a WeakPtr<>. <rdar://110485192>

Attachments
Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2023-06-10 13:41:01 PDT

Pull request: https://github.com/WebKit/WebKit/pull/14849

EWS

Comment 2 2023-06-13 06:50:48 PDT

Committed 265120@main (946a761a0a7f): <https://commits.webkit.org/265120@main> Reviewed commits have been landed. Closing PR #14849 and removing active labels.

David Kilzer (:ddkilzer)

Comment 3 2023-06-13 06:56:47 PDT

<rdar://110349418>

Note You need to log in before you can comment on or make changes to this bug.