Bug 257985
| Summary: | [iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox (Part 2) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
In Bug 256728, I attempted to enable `SYS_faccessat` in the iOS sandbox, as we had telemetry indicating it was getting hit.
Unfortunately, this caused a memory benchmark to regress by a small amount. Without a strong reason to keep the feature accessible, we decided to silence it to avoid the cost of symbolicating telemetry and reports.
Since then, I have discovered that some aspects of Metal's shader caching needs this value. This patch restores the feature. I will work to determine whether this is a true memory regression, or simply reverting a mistaken memory progression created when we blocked it in our April code release.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://108203015>
Brent Fulgham
<rdar://problem/108203015>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/14895