Bug 258051
| Summary: | Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 257938 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS.
Since both m_webView and m_contentView are WeakObjCPtr<> instance variables, calling methods like `[m_webView bar]` results in autoreleasing `m_webView` every time.
Fix this by using convenience methods that call WeakObjCPtr<>::get() and return a RetainPtr<> instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110740310>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/14938
EWS
Committed 265157@main (3fe8f3b95be5): <https://commits.webkit.org/265157@main>
Reviewed commits have been landed. Closing PR #14938 and removing active labels.