Bug 258073

Summary:	Implement 'dirtiness' of HTMLOptionElement
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Forms	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	annevk, cdumez, cyb.ai.815, karlcow, mike, ntim, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
URL:	http://wpt.live/html/semantics/forms/the-option-element/option-selected.html
See Also:	https://github.com/whatwg/html/issues/9682

Description Ahmad Saleem 2023-06-14 05:05:59 PDT

Hi Team,

We need to implement 'dirtiness' for HTMLOptionElement to pass following failing WPT tests:

Test: https://wpt.fyi/results/html/semantics/forms/the-option-element/option-selected.html?label=experimental&label=master&aligned

Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/a17cc1eda58ad8270dc56ebafab215e67e6c1bfe

Just wanted to raise, so we can fix it.

Thanks!

Comment 1 Tim Nguyen (:ntim) 2023-06-14 20:07:22 PDT

Seems like an 1:1 port.

Comment 2 Ahmad Saleem 2023-06-18 16:27:47 PDT

Blink patch will cause regression, so this is follow-up: https://chromium.googlesource.com/chromium/src.git/+/f67251360e4b76d188bb1523d7a0952c2f449e68

Comment 3 Ahmad Saleem 2023-06-18 16:37:45 PDT

(In reply to Ahmad Saleem from comment #2)
> Blink patch will cause regression, so this is follow-up:
> https://chromium.googlesource.com/chromium/src.git/+/
> f67251360e4b76d188bb1523d7a0952c2f449e68

Also another regression: https://chromium.googlesource.com/chromium/src/+/6d095ec7a71eb72e2ad9992d1ca3080f5726f6bf

Comment 4 Radar WebKit Bug Importer 2023-06-21 05:06:17 PDT

<rdar://problem/111096541>

Comment 5 Ahmad Saleem 2023-07-07 08:40:20 PDT

I merged these patches and got them compiled but got crashes in three tests. So I might be doing something wrong. Happy to zip and attach screenshots of my local patches.

Comment 6 Ahmad Saleem 2024-07-14 12:53:28 PDT

I tried this again locally and now running via WIP to see what happens - last time it caused crashes locally but this time didn't.

https://github.com/WebKit/WebKit/pull/30802

In WIP / Draft - would be good to at least post what I tried locally.

Comment 7 Ahmad Saleem 2024-07-15 07:48:04 PDT

Just documenting progress on bug rather than PR - it leads to failing two tests:

accessibility/listbox-clear-selection.html 
accessibility/select-element-at-index.html

I haven't explored yet but good to maintain list (some time old EWS runs are not accessible - hence documenting it here).