Bug 258095

Summary: ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData): [ iOS, macOS ] media/track/video-track-add-remove.html is a flaky crash.
Product: WebKit Reporter: Bri Harris <bharris9>
Component: CompositingAssignee: Bri Harris <bharris9>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: eric.carlson, jenner, jer.noble, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=258097

Description Bri Harris 2023-06-14 14:34:45 PDT
media/track/video-track-add-remove.html 

is a flaky crash on iOS 16 and macOS Debug queues.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Fvideo-track-add-remove.html



STDERR TEXT:
ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData)
/Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebCore/rendering/RenderLayerCompositor.cpp(1201) : void WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer *, WebCore::RenderLayer &, WebCore::LayerOverlapMap &, WebCore::RenderLayerCompositor::CompositingState &, WebCore::RenderLayerCompositor::BackingSharingState &, bool &)
1   0x151014550 WTFCrash
2   0x1073990f0 WebCore::NetworkResourcesData::ResourceData::hasContent() const
3   0x10847b9a8 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&)
4   0x10847b638 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&)
5   0x10847b6c0 WebCore::RenderLayerCompositor::computeCompositingRequirements(WebCore::RenderLayer*, WebCore::RenderLayer&, WebCore::LayerOverlapMap&, WebCore::RenderLayerCompositor::CompositingState&, WebCore::RenderLayerCompositor::BackingSharingState&, bool&)
6   0x108479778 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*)
7   0x107903460 WebCore::LocalFrameView::updateCompositingLayersAfterLayout()
8   0x10790678c WebCore::LocalFrameView::didLayout(WTF::WeakPtr<WebCore::RenderElement, WTF::DefaultWeakPtrImpl>)
9   0x10791f5dc WebCore::LocalFrameViewLayoutContext::performLayout()
10  0x1078fdd0c WebCore::LocalFrameViewLayoutContext::layout()
11  0x107918ac8 WebCore::LocalFrameView::updateLayoutAndStyleIfNeededRecursive()
12  0x107973608 WebCore::Page::layoutIfNeeded()
13  0x107974088 WebCore::Page::updateRendering()
14  0x12c9c63ac WebKit::WebPage::updateRendering()
15  0x12bc1fecc WebKit::TiledCoreAnimationDrawingArea::updateRendering(WebKit::TiledCoreAnimationDrawingArea::UpdateRenderingType)
16  0x12bc23c28 WebKit::TiledCoreAnimationDrawingArea::renderingUpdateRunLoopCallback()
17  0x12bc25900 WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea(WebKit::WebPage&, WebKit::WebPageCreationParameters const&)::$_0::operator()() const
18  0x12bc258ac WTF::Detail::CallableWrapper<WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea(WebKit::WebPage&, WebKit::WebPageCreationParameters const&)::$_0, void>::call()
19  0x106271a7c WTF::Function<void ()>::operator()() const
20  0x107b87eb0 WebCore::RunLoopObserver::runLoopObserverFired()
21  0x107c5ecc4 WebCore::RunLoopObserver::runLoopObserverFired(__CFRunLoopObserver*, unsigned long, void*)
22  0x1961f19f0 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
23  0x1961f18dc __CFRunLoopDoObservers
24  0x1961f0514 CFRunLoopRunSpecific
25  0x197169fcc -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
26  0x1971e2ccc -[NSRunLoop(NSRunLoop) run]
27  0x195e62594 _xpc_objc_main
28  0x195e61eb4 xpc_main
29  0x12af6c9f8 WebKit::XPCServiceMain(int, char const**)
30  0x12cef47cc WKXPCServiceMain
31  0x1001ebfa0 main
com.apple.WebKit.WebContent.Development terminated (pid 34287) for reason: crash
LEAK: 1 WebPageProxy
Comment 1 Radar WebKit Bug Importer 2023-06-14 14:35:03 PDT
<rdar://problem/110799457>
Comment 2 Bri Harris 2023-06-14 16:13:15 PDT
I attempted to replicate this crash on Ventura ToT as follows:


 run-webkit-tests --root media/track/video-track-add-remove.html --force --debug
Comment 3 Bri Harris 2023-06-14 17:30:18 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14979
Comment 4 EWS 2023-06-14 17:35:54 PDT
Test gardening commit 265172@main (aaa200de92eb): <https://commits.webkit.org/265172@main>

Reviewed commits have been landed. Closing PR #14979 and removing active labels.
Comment 5 Robert Jenner 2023-06-20 14:50:52 PDT

*** This bug has been marked as a duplicate of bug 257970 ***