Bug 258154

Summary:	Serialization algorithms should not be changed in the middle of a serialization
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	WebCore Misc.	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Chris Dumez 2023-06-15 13:25:31 PDT

Some of the code in MarkupAccumulator would rely on the node's document to determine whether or not to use the XML or HTML serialization algorithm instead of using the serialization algorithm passed to the MarkupAccumulator constructor. This is often fine but leads to behavior changes when the node is a <template> since they have their own template document.

This meant that we may start serialization as HTML and then switch to XML for serialization a particular template node.

Comment 1 Chris Dumez 2023-06-15 13:31:08 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15016

Comment 2 EWS 2023-06-16 09:50:15 PDT

Committed 265248@main (bb36b71707e3): <https://commits.webkit.org/265248@main>

Reviewed commits have been landed. Closing PR #15016 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-06-16 09:51:18 PDT

<rdar://problem/110905261>