Bug 258167
| Summary: | Check CachedResourceLoader's document WeakPtr in more places | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
The CachedResourceLoader class holds a WeakPtr to a Document, which may be nullptr at different moments in loading. We inconsistently check for nullptr, which telemetry shows is triggering some crashes.
This patch provides more rigorous checks for nullptr to avoid these crashes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://106964279>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/15025
EWS
Committed 265259@main (9632def06c0f): <https://commits.webkit.org/265259@main>
Reviewed commits have been landed. Closing PR #15025 and removing active labels.