Bug 258201
| Summary: | [GTK] Build failure: m_page not declared in this scope | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kdwk <kdwkleung> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Kdwk
With WebKit main, building WebKitGTK fails:
In file included from /app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:27,
from /app/webkit/WebKitBuild/Release/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-22.cpp:1:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.h:57:5: error: ‘WeakPtr’ does not name a type
57 | WeakPtr<WebPage> m_page;
| ^~~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In constructor ‘WebKit::WebColorChooser::WebColorChooser(WebKit::WebPage*, WebCore::ColorChooserClient*, const WebCore::Color&)’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:42:7: error: class ‘WebKit::WebColorChooser’ does not have any field named ‘m_page’
42 | , m_page(page)
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:44:5: error: ‘m_page’ was not declared in this scope; did you mean ‘page’?
44 | m_page->setActiveColorChooser(this);
| ^~~~~~
| page
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In destructor ‘virtual WebKit::WebColorChooser::~WebColorChooser()’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:50:10: error: ‘m_page’ was not declared in this scope
50 | if (!m_page)
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:53:5: error: ‘m_page’ was not declared in this scope
53 | m_page->setActiveColorChooser(0);
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In member function ‘void WebKit::WebColorChooser::disconnectFromPage()’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:68:5: error: ‘m_page’ was not declared in this scope
68 | m_page = 0;
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In member function ‘virtual void WebKit::WebColorChooser::reattachColorChooser(const WebCore::Color&)’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:74:5: error: ‘m_page’ was not declared in this scope
74 | m_page->setActiveColorChooser(this);
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In member function ‘virtual void WebKit::WebColorChooser::setSelectedColor(const WebCore::Color&)’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:82:10: error: ‘m_page’ was not declared in this scope
82 | if (!m_page)
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:85:9: error: ‘m_page’ was not declared in this scope
85 | if (m_page->activeColorChooser() != this)
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:88:113: error: ‘m_page’ was not declared in this scope
88 | WebProcess::singleton().parentProcessConnection()->send(Messages::WebPageProxy::SetColorPickerColor(color), m_page->identifier());
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp: In member function ‘virtual void WebKit::WebColorChooser::endChooser()’:
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:93:10: error: ‘m_page’ was not declared in this scope
93 | if (!m_page)
| ^~~~~~
/app/webkit/Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:96:103: error: ‘m_page’ was not declared in this scope
96 | WebProcess::singleton().parentProcessConnection()->send(Messages::WebPageProxy::EndColorPicker(), m_page->identifier());
| ^~~~~~
[1342/1636] Building CXX object Sourc...urces/UnifiedSource-54928a2b-25.cpp.o
ninja: build stopped: subcommand failed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Try adding:
#include <wtf/WeakPtr.h>
Michael Catanzaro
(in WebColorChooser.h)
Kdwk
Yup that worked
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/15069
EWS
Committed 265272@main (45f89a45d4d0): <https://commits.webkit.org/265272@main>
Reviewed commits have been landed. Closing PR #15069 and removing active labels.