Bug 258216

Summary:

REGRESSION(262277@main): wpt/css/CSS2/floats/floats-rule3-outside-left-001.xht

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=254394
https://bugs.webkit.org/show_bug.cgi?id=209735

Attachments:

Description	Flags
Patch	none
[fast-cq]Patch	ews-feeder: commit-queue-

Description Sam Sneddon [:gsnedders] 2023-06-16 09:21:08 PDT

c.f. https://wpt.fyi/results/css/CSS2/floats?label=master&product=chrome%5Bexperimental%5D&product=firefox%5Bexperimental%5D&product=safari-167%20preview%5Bexperimental%5D&product=safari-172%20preview&product=safari%5Bstable%5D&q=floats-rule3-outside%20%20001

bisect points at 262277@main as the culprit

we don't have this imported in WebKit (bug 209735)

see https://wpt.fyi/results/css/CSS2/floats/floats-rule3-outside-left-001.xht and https://wpt.fyi/results/css/CSS2/floats/floats-rule3-outside-right-001.xht

Comment 1 Radar WebKit Bug Importer 2023-06-16 09:21:20 PDT

<rdar://problem/110903782>

Comment 2 zalan 2023-06-16 10:41:14 PDT

While working on a test reduction I noticed that both Chrome and Firefox let floats overlap
https://jsfiddle.net/65h4eykx/1/
very sus.

Comment 3 zalan 2023-06-20 12:20:17 PDT

Created attachment 466764 [details]
Patch

Comment 4 Antti Koivisto 2023-06-20 12:27:12 PDT

Comment on attachment 466764 [details]
Patch

Gallery quality ASCII art

Comment 5 zalan 2023-06-20 12:31:04 PDT

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 466764 [details]
> Patch
> 
> Gallery quality ASCII art
don't give me ideas

Comment 6 zalan 2023-06-20 14:06:53 PDT

Created attachment 466767 [details]
[fast-cq]Patch

Comment 7 EWS 2023-06-20 20:51:56 PDT

Committed 265345@main (c03d0ac6e6db): <https://commits.webkit.org/265345@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466767 [details].