| Summary: | [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow spec language | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 258235 | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2023-06-17 10:16:37 PDT
Created attachment 466737 [details]
Patch
Comment on attachment 466737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466737&action=review > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131 > + auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) { wouldn't it be cleaner to just return the finalSize? Created attachment 466760 [details]
[fast-cq]Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 466737 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466737&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131 > > + auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) { > > wouldn't it be cleaner to just return the finalSize? yeah, not sure what happened here. Committed 265308@main (521acb6278c9): <https://commits.webkit.org/265308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466760 [details]. |