Bug 258326

Summary:	input type=tel test case fail in css/selectors/dir-pseudo-on-input-element.html
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	CSS	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rniwa, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-06-20 15:23:59 PDT

Hi Team,

I think we special cased 'telephone' directionality [1] in the past but now we fail the WPT test:

[1] https://commits.webkit.org/252779@main

>> (WebCore::HTMLElement::computeDirectionality const): Added a special case for telephone.

[2] https://commits.webkit.org/254017@main

^ This modified the above function but still had the 'telephone' cases, which we still have.

Live Link: http://wpt.live/css/selectors/dir-pseudo-on-input-element.html

It started failing with latest WPT import: https://commits.webkit.org/258889@main

So I think either we need to remove special casing or we missed bit and need to fix it.

Just raising so we can fix this failing test as well.

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-06-21 11:22:26 PDT

<rdar://problem/111114056>

Comment 2 Ryosuke Niwa 2023-06-24 01:27:22 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15273

Comment 3 EWS 2023-06-24 19:27:49 PDT

Committed 265500@main (1f2d2a92eeb8): <https://commits.webkit.org/265500@main>

Reviewed commits have been landed. Closing PR #15273 and removing active labels.