Bug 258332

Summary:	REGRESISON(265142@Main): [ Debug iOS, macOS x86_64] imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html is a constant crash
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	Media	Assignee:	youenn fablet <youennf>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	eric.carlson, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=257749

Description Robert Jenner 2023-06-20 18:00:09 PDT

imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html

is a constant crash on debug iOS, and debug macOS but only on Intel for Mac. 

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebcodecs%2FvideoFrame-construction.crossOriginSource.sub.html

CRASHLOG URL:
https://build.webkit.org/results/Apple-Ventura-Debug-WK2-Tests/265332@main%20(2488)/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub-crash-log.txt

CRASHLOG TEXT:
SHOULD NEVER BE REACHED
/Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebCore/platform/VideoPixelFormat.cpp(49) : WebCore::VideoPixelFormat WebCore::convertVideoFramePixelFormat(uint32_t, bool)
1   0x2a8daa519 WTFCrash
2   0x25b1e928b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x25fa2caee WebCore::convertVideoFramePixelFormat(unsigned int, bool)
4   0x25ddfe208 WebCore::WebCodecsVideoFrame::initializeFrameFromOtherFrame(WebCore::ScriptExecutionContext&, WTF::Ref<WebCore::VideoFrame, WTF::RawPtrTraits<WebCore::VideoFrame>>&&, WebCore::WebCodecsVideoFrame::Init&&)
5   0x25de23586 WebCore::WebCodecsVideoFrame::create(WebCore::ScriptExecutionContext&, std::__1::variant<WTF::RefPtr<WebCore::HTMLImageElement, WTF::RawPtrTraits<WebCore::HTMLImageElement>, WTF::DefaultRefDerefTraits<WebCore::HTMLImageElement>>, WTF::RefPtr<WebCore::SVGImageElement, WTF::RawPtrTraits<WebCore::SVGImageElement>, WTF::DefaultRefDerefTraits<WebCore::SVGImageElement>>,

Comment 1 Radar WebKit Bug Importer 2023-06-20 18:01:07 PDT

<rdar://problem/111073090>

Comment 2 Robert Jenner 2023-06-20 18:12:19 PDT

I have marked an expectation for this test here:
https://commits.webkit.org/265340@main

I was also able to reproduce the crash at iOS 16 Debug ToT running the test as follows:

Run-webkit-tests --iOS-simulator imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html

I verified that the same crash is seen on Intel Mac Debug, and iOS Debug. I have also bisected to a specific regression point. 265142@main appears to have broken this test, causing it to crash. 

I set my checkout to 265141@main, and re-ran the test at the same iOS16 Debug ToT build and the crash did not reproduce. I then updated the checkout to 265142@main, and re-ran the test again and the crashing returned.

Comment 3 youenn fablet 2023-06-22 04:49:03 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15192

Comment 4 EWS 2023-06-22 08:55:27 PDT

Committed 265405@main (156e8c02d46b): <https://commits.webkit.org/265405@main>

Reviewed commits have been landed. Closing PR #15192 and removing active labels.