Bug 258405

Summary: Clean-up RenderFrameSet.cpp|h by removing dead code
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-06-22 09:17:56 PDT
Hi Team,

While going through Blink's commit, I came across potential opportunity to do some 'simplify' and 'clean-up' in 'RenderFrameSet' layout & rendering code:

Blink Commit (1): https://src.chromium.org/viewvc/blink?view=revision&revision=171899

- Deleting RenderFrameSet::isResizingRow() & RenderFrameSet::isResizingColumn()

Blink Commit (2): https://chromium.googlesource.com/chromium/src.git/+/7985904656b18a02548afcf98cce20f3353a73f9

- https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#60 (Deleting 'm_isChildResizing' & removing 'Line 593 & 594')

Just wanted to raise so we can do this clean-up.

@Alan & @Simon - any comment?

Thanks!
Comment 1 EWS 2023-06-22 11:58:41 PDT
Committed 265417@main (d0daa5ec56a5): <https://commits.webkit.org/265417@main>

Reviewed commits have been landed. Closing PR #15197 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-06-22 11:59:17 PDT
<rdar://problem/111174263>