Bug 258437

Summary:	Attachment: Move image display from legacy to modern implementation
Product:	WebKit	Reporter:	Gerald Squelart <g_squelart>
Component:	HTML Editing	Assignee:	Gerald Squelart <g_squelart>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	251830
Bug Blocks:	258844, 267838

Description Gerald Squelart 2023-06-22 22:28:55 PDT

Replace the inner legacy attachment with a standard `<img>` element.

<rdar://105252742>

Comment 1 Gerald Squelart 2023-06-22 22:46:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15228

Comment 2 EWS 2023-06-29 04:05:23 PDT

Committed 265615@main (b0e7ef7b0420): <https://commits.webkit.org/265615@main>

Reviewed commits have been landed. Closing PR #15228 and removing active labels.

Comment 3 Gerald Squelart 2023-06-29 13:42:19 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/15421

Comment 4 EWS 2023-06-29 13:51:10 PDT

Committed 265629@main (61d2643b6fe6): <https://commits.webkit.org/265629@main>

Reviewed commits have been landed. Closing PR #15421 and removing active labels.

Comment 5 Jonathan Bedard 2023-07-11 15:53:50 PDT

Looks like this flakily regressed fast/attachment/cocoa/wide-attachment-folder-icon.html

Comment 6 Jonathan Bedard 2023-07-11 15:54:01 PDT

https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fcocoa%2Fwide-attachment-folder-icon.html

Comment 7 Gerald Squelart 2023-07-11 16:16:12 PDT

Thank you Jonathan.
I believe it may have made a few wide-attachment-* tests flaky, because of the way the icon is asynchronously fetched and then loaded into an img.
I'm working on bug 258865, which should solve this.