Bug 258509

Summary:	[Curl] Coding style issue in ResourceResponse.h
Product:	WebKit	Reporter:	Kenji Shukuwa <kenji.shukuwa>
Component:	Platform	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Kenji Shukuwa 2023-06-26 00:20:37 PDT

ERROR: Source/WebCore/platform/network/curl/ResourceResponse.h:63:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]

Comment 1 Kenji Shukuwa 2023-06-26 00:34:45 PDT

Removing WEBCORE_EXPORT from a class means adding WEBCORE_EXPORT to many functions.

However, if you remove the functions that hide status code checks such as isMovedPermanently and write the status code directly in the code like other ports, they will be unnecessary.

I would like to refer to the SOUP port and modify the code.

Comment 2 Kenji Shukuwa 2023-06-26 00:37:29 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15287

Comment 3 EWS 2023-06-26 20:40:57 PDT

Committed 265537@main (593b1ac94072): <https://commits.webkit.org/265537@main>

Reviewed commits have been landed. Closing PR #15287 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-06-26 20:41:35 PDT

<rdar://problem/111368722>