Bug 258517
| Summary: | Source/JavaScriptCore/CMakeLists.txt: putting __TIMESTAMP__ into a generated file is non-reproducible behavior | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexander Kanavin <alex.kanavin> |
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, berto, emw, fujii.hironori, mark.lam, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=247622 | ||
Alexander Kanavin
__TIMESTAMP__ refers to mtime of the file that contains it, which is unstable
and breaks binary reproducibility when the file is generated at build time. To ensure
this does not happen, mtime should be set from the original file.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
*** This bug has been marked as a duplicate of bug 252308 ***
EWS
Committed 266322@main (8e2834324073): <https://commits.webkit.org/266322@main>
Reviewed commits have been landed. Closing PR #15293 and removing active labels.
Michael Catanzaro
*** Bug 252308 has been marked as a duplicate of this bug. ***