Bug 258517

Summary:	Source/JavaScriptCore/CMakeLists.txt: putting __TIMESTAMP__ into a generated file is non-reproducible behavior
Product:	WebKit	Reporter:	Alexander Kanavin <alex.kanavin>
Component:	CMake	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, berto, emw, Hironori.Fujii, mark.lam, mcatanzaro
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=247622

Description Alexander Kanavin 2023-06-26 05:58:25 PDT

__TIMESTAMP__ refers to mtime of the file that contains it, which is unstable
and breaks binary reproducibility when the file is generated at build time. To ensure
this does not happen, mtime should be set from the original file.

Comment 1 Michael Catanzaro 2023-06-26 13:56:46 PDT


*** This bug has been marked as a duplicate of bug 252308 ***

Comment 2 EWS 2023-07-26 12:15:39 PDT

Committed 266322@main (8e2834324073): <https://commits.webkit.org/266322@main>

Reviewed commits have been landed. Closing PR #15293 and removing active labels.

Comment 3 Michael Catanzaro 2023-08-10 14:22:42 PDT

*** Bug 252308 has been marked as a duplicate of this bug. ***