Bug 258554

Summary:	Missing ENABLE(WEBASSEMBLY_B3JIT) guard in Wasm interpreter implementation
Product:	WebKit	Reporter:	Hayashida Ryuichi <Ryuichi.Hayashida>
Component:	JavaScriptCore	Assignee:	Ross Kirsling <ross.kirsling>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	222315

Description Hayashida Ryuichi 2023-06-27 03:01:47 PDT

WEBASSEMBLY is ON and ENABLE_FTL_JIT is OFF cause build errors since Wasm interpreter implementation misses ENABLE(WEBASSEMBLY_B3JIT) guard in some member functions.

At least the following member functions need to be fixed considering the case where WEBASSEMBLY_B3JIT is OFF. For example,

- StackVisitor::readInlinableWasmFrame
- OptimizingJITCallee::addCodeOrigin

More APIs would need similar fix.

Comment 1 Ross Kirsling 2023-07-02 21:10:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15490

Comment 2 Radar WebKit Bug Importer 2023-07-04 03:02:15 PDT

<rdar://problem/111732867>

Comment 3 EWS 2023-07-05 19:09:04 PDT

Committed 265786@main (441ba4d830a0): <https://commits.webkit.org/265786@main>

Reviewed commits have been landed. Closing PR #15490 and removing active labels.