| Summary: | Generated IPC serializers for MoveOnlyBaseClass&& are incorrect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebKit2 | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | g_squelart, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=257581 | ||
| Bug Depends on: | |||
| Bug Blocks: | 257580 | ||
Maybe you're right that when using downcast, it is consistent with by-ref encoding. I don't remember what was the idea why it's bad. The only thing I could re-comeup with is that MoveOnlyDerivedClass might not be the final class, so then moving parts of the class is not ok. Comparing to by-ref encoding, copying only part of the class is ok from the safety perspective. However, it's not probably intended so both would be equally buggy and as such rvalue ref code would be consistent with ref code. |
Generated IPC serializers forMoveOnlyBaseClass&& are incorrect It appears that the code tries to implement move through base class rvalue reference. It is not possible in general case following c++ rvalue semantics, as rvalue constructors are not polymorphic. Move makes no sense: void ArgumentCoder<WebCore::MoveOnlyBaseClass>::encode(Encoder& encoder, WebCore::MoveOnlyBaseClass&& instance) { if (auto* subclass = dynamicDowncast<WebCore::MoveOnlyDerivedClass>(instance)) { encoder << WebCore_MoveOnlyBaseClass_Subclass::MoveOnlyDerivedClass; encoder << WTFMove(*subclass); return; } ASSERT_NOT_REACHED(); }