Bug 258625

Summary:	Fix JavaScriptCore build on oss-fuzz
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	Web Template Framework	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	CLOSED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58850

Description David Kilzer (:ddkilzer) 2023-06-28 08:50:32 PDT

Fix JavaScriptCore build on oss-fuzz.

Step #3 - "compile-none-address-x86_64": /usr/local/bin/clang++ -DBUILDING_JSCONLY__ -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DHAVE_CONFIG_H=1 -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_bmalloc -I/src/WebKit/WebKitBuild/Debug -I/src/WebKit/WebKitBuild/Debug/WTF/DerivedSources -I/src/WebKit/Source/WTF -I/src/WebKit/Source/WTF/wtf -I/src/WebKit/Source/WTF/wtf/dtoa -I/src/WebKit/Source/WTF/wtf/fast_float -I/src/WebKit/Source/WTF/wtf/persistence -I/src/WebKit/Source/WTF/wtf/text -I/src/WebKit/Source/WTF/wtf/text/icu -I/src/WebKit/Source/WTF/wtf/threads -I/src/WebKit/Source/WTF/wtf/unicode -I/src/WebKit/WebKitBuild/Debug/bmalloc/Headers -isystem /src/deps/include -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope  -stdlib=libc++ -DU_STATIC_IMPLEMENTATION -fno-strict-aliasing -fno-exceptions -fno-rtti -g -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Werror -std=c++20 -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o -c /src/WebKit/Source/WTF/wtf/text/TextBreakIterator.cpp
Step #3 - "compile-none-address-x86_64": /src/WebKit/Source/WTF/wtf/text/TextBreakIterator.cpp:134:71: error: macro 'ATOMIC_VAR_INIT' has been marked as deprecated [-Werror,-Wdeprecated-pragma]
Step #3 - "compile-none-address-x86_64": static std::atomic<UBreakIterator*> nonSharedCharacterBreakIterator = ATOMIC_VAR_INIT(nullptr);
Step #3 - "compile-none-address-x86_64":                                                                       ^
Step #3 - "compile-none-address-x86_64": /usr/local/bin/../include/c++/v1/atomic:2709:43: note: macro marked 'deprecated' here
Step #3 - "compile-none-address-x86_64": #  pragma clang deprecated(ATOMIC_VAR_INIT)
Step #3 - "compile-none-address-x86_64":                                           ^
Step #3 - "compile-none-address-x86_64": 1 error generated.

<https://oss-fuzz-build-logs.storage.googleapis.com/log-90f78f23-a141-4a4d-957f-b779d521881c.txt>

See:  <https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58850>

Comment 1 Radar WebKit Bug Importer 2023-06-28 08:53:19 PDT

<rdar://problem/111454222>

Comment 2 David Kilzer (:ddkilzer) 2023-06-28 08:56:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15373

Comment 3 EWS 2023-06-28 09:45:45 PDT

Committed 265585@main (2b3bfa9afb6a): <https://commits.webkit.org/265585@main>

Reviewed commits have been landed. Closing PR #15373 and removing active labels.

Comment 4 David Kilzer (:ddkilzer) 2023-07-04 08:32:10 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/15543

Comment 5 EWS 2023-07-04 09:46:02 PDT

Committed 265756@main (ee9d5f08a78b): <https://commits.webkit.org/265756@main>

Reviewed commits have been landed. Closing PR #15543 and removing active labels.

Comment 6 David Kilzer (:ddkilzer) 2023-07-10 09:51:40 PDT

Next build failure:

Step #3 - "compile-none-address-x86_64": /src/WebKit/Source/JavaScriptCore/API/tests/FunctionToStringTests.cpp:107:5: error: use of undeclared identifier 'printf'
Step #3 - "compile-none-address-x86_64":      printf("%s: function toString tests.\n", failed ? "FAIL" : "PASS");
Step #3 - "compile-none-address-x86_64":      ^
Step #3 - "compile-none-address-x86_64": error generated.

<https://oss-fuzz-build-logs.storage.googleapis.com/log-5ced79d5-e42d-4944-8724-011b4c1d599b.txt>

Comment 7 David Kilzer (:ddkilzer) 2023-07-10 09:54:06 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/15698

Comment 8 EWS 2023-07-10 10:40:35 PDT

Committed 265910@main (cbe26af65a98): <https://commits.webkit.org/265910@main>

Reviewed commits have been landed. Closing PR #15698 and removing active labels.