Bug 258707

Summary:	[GTK][WPE] Flush TestWebKitAPI binaries before building
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	New Bugs	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=248382

Description Diego Pino 2023-06-29 19:25:00 PDT

It happened in https://bugs.webkit.org/show_bug.cgi?id=248382 that the bots were reporting tests failures on a test that was no longer part of the sources. That binary was a leftover from previous builds.

So, to avoid ending up in situations like this (which actually happened recently again), the TestWebKitAPI directory should only contain binaries that are present in the codebase. This could be achieve by listing which Test binaries to run (this is actually how the script is working right now, but when the target is a dir the script simply pulls all contents in the dir):

https://searchfox.org/wubkat/source/Tools/Scripts/run-wpe-tests#35

Another alternative is to flush the TestWebKitAPI directory before building.

Comment 1 Diego Pino 2023-06-29 19:29:08 PDT

Pull request: https://github.com/webkit/webkit/pull/15431

Comment 2 EWS 2023-06-30 04:04:58 PDT

Committed 265650@main (61011010ac86): <https://commits.webkit.org/265650@main>

Reviewed commits have been landed. Closing PR #15431 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2023-06-30 04:05:19 PDT

<rdar://problem/111561724>