Bug 258734

Summary: REGRESSION(265569@main): All path segments should be coded by StreamConnectionEncoder
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=255898
https://bugs.webkit.org/show_bug.cgi?id=258762

Description Said Abou-Hallawa 2023-06-30 08:30:23 PDT
After 265569@main, the composite path segments, such as PathDataLine, became decodable by IPC coders only. We need to add StreamConnectionEncoder as additional coder for encoding and decoding them. The reason for this change in 265569@main, was the serialization.in files do not know hot to deal with template struct/class. These composite path segments are defined as templates for two types. So the encoding/decoding code was implemented in WebCoreArgumentCoders.h. This caused a perf regression in MotionMark CanvasLines subtest.
Comment 1 Radar WebKit Bug Importer 2023-06-30 08:30:45 PDT
<rdar://problem/111570644>
Comment 2 Said Abou-Hallawa 2023-06-30 09:15:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15451
Comment 3 EWS 2023-06-30 19:27:22 PDT
Committed 265680@main (7dc4e7c7d38b): <https://commits.webkit.org/265680@main>

Reviewed commits have been landed. Closing PR #15451 and removing active labels.