Bug 258827

Summary: Bug 258793 follow-up: Add test to exercise the null-decoder-with-NoError path in Connection::sendSyncMessage and StreamClientConnection::trySendSyncStream
Product: WebKit Reporter: Gerald Squelart <g_squelart>
Component: WebKit Process ModelAssignee: Kimmo Kinnunen <kkinnunen>
Status: NEW ---    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 258793, 258861    
Bug Blocks:    

Description Gerald Squelart 2023-07-03 14:55:31 PDT 
Bug 258793 modified `Connection::sendSyncMessage` to handle a code path that could potential return a null `Decoder` pointer along with an `Error::NoError`, which could eventually lead callers (e.g.: `WebPaymentCoordinator::canMakePayments`) to attempt to read the value of an empty `std::optional`.

Unless the real root cause is found that would remove this code path entirely, it would be good to add a proper test that exercises it.
Comment 1 Gerald Squelart 2023-07-05 02:44:24 PDT 
Bug 258861 added a couple of other similar fixes in StreamClientConnection::trySendSyncStream.
Comment 2 Radar WebKit Bug Importer 2023-07-10 14:56:41 PDT 
<rdar://problem/112040784>