Bug 258868
| Summary: | Correctly compute baseline of wide-layout attachments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | HTML Editing | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 259172, 259039 | ||
Gerald Squelart
Currently it's falling back on the narrow/legacy renderer's baseline computation, which happens to look okay.
This should be fixed to have a proper computation.
Also, because it's currently going through the legacy layout path, HTMLAttachmentElement::requestIconWithSize triggers its debug-assertion that it should only be used with a narrow/legacy attachment; in release it doesn't crash but probably does an extra unnecessary icon request.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/111771870>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/15558
EWS
Committed 265831@main (ee150aed9da8): <https://commits.webkit.org/265831@main>
Reviewed commits have been landed. Closing PR #15558 and removing active labels.