Bug 259010

Summary:	Add comment about duplicate check in 'checkInvalidControlsAndCollectUnhandled' function within 'if' clause
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Forms	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-07-08 01:03:40 PDT

Bug to remove duplicate check from this:

https://github.com/WebKit/WebKit/blob/da535631d69cc22753758c77b058981ee8bb3e09/Source/WebCore/html/HTMLFormElement.cpp#L811

We have:

if (control->form() == this && !control->checkValidity(&unhandledInvalidControls) && control->form() == this)

Which can be just:

if (!control->checkValidity(&unhandledInvalidControls) && control->form() == this)

______

Just raising to fix this.

Thanks!

Comment 1 Ahmad Saleem 2023-07-08 02:41:03 PDT

This is needed for: fast/forms/interactive-validation-remove-node-in-handler.html & fast/forms/checkValidity-handler-updates-dom.html

Comment 2 Ahmad Saleem 2023-07-09 07:20:27 PDT

Reopening to add explanatory comment.

Comment 3 EWS 2023-07-09 11:46:38 PDT

Committed 265890@main (e7780d735de3): <https://commits.webkit.org/265890@main>

Reviewed commits have been landed. Closing PR #15663 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2023-07-09 11:47:17 PDT

<rdar://problem/111982031>