Bug 259090

Summary:	[Win][Clang] gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString'
Product:	WebKit	Reporter:	Fujii Hironori <fujii.hironori>
Component:	New Bugs	Assignee:	Fujii Hironori <fujii.hironori>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	171618

Fujii Hironori

Reported 2023-07-10 18:40:16 PDT

clang-cl reports a warning: [1168/6517] Building CXX object Source\ThirdParty\gtest\CMakeFiles\gtest.dir\src\gtest-filepath.cc.obj C:\home\webkit\gc\Source\ThirdParty\gtest\src\gtest-filepath.cc(68,12): warning: unused variable 'kAlternatePathSeparatorString' [-Wunused-const-variable] const char kAlternatePathSeparatorString[] = "/"; ^ 1 warning generated.

Attachments
Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2023-07-10 18:41:11 PDT

clang-cl doesn't reprot this warning for the upstream google-test. It's using gtest-all.cc. Let's use it in WebKit too.

Fujii Hironori

Comment 2 2023-07-10 18:51:07 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15723

EWS

Comment 3 2023-07-12 22:35:02 PDT

Committed 266025@main (805f2b51a351): <https://commits.webkit.org/266025@main> Reviewed commits have been landed. Closing PR #15723 and removing active labels.

Radar WebKit Bug Importer

Comment 4 2023-07-12 22:36:17 PDT

<rdar://problem/112178499>

Note You need to log in before you can comment on or make changes to this bug.