Bug 259108

Summary: WTF/wtf/threads/Signals.cpp lacks Windows implementation
Product: WebKit Reporter: Hayashida Ryuichi <Ryuichi.Hayashida>
Component: Web Template FrameworkAssignee: Hayashida Ryuichi <Ryuichi.Hayashida>
Status: RESOLVED FIXED    
Severity: Normal CC: Hironori.Fujii, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=260222
Bug Depends on:    
Bug Blocks: 222315    

Description Hayashida Ryuichi 2023-07-11 06:40:44 PDT 
Signal handlers implementation in WTF/wtf/threads/Signals.cpp assumes only Unix platforms (OS(UNIX) is enabled). Windows implementation is necessary to support signal handlers for Wasm implementation at JavaScriptCore/wasm/WasmFaultSignalHandler.cpp. Same interface as Unix platforms would be implemented with Windows signal API.

s://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/signal
Comment 1 Radar WebKit Bug Importer 2023-07-18 06:41:21 PDT 
<rdar://problem/112467230>
Comment 2 Ian Grunert 2023-08-04 11:00:59 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16396
Comment 3 EWS 2023-08-08 22:39:40 PDT 
Committed 266716@main (66b9bc907a2e): <https://commits.webkit.org/266716@main>

Reviewed commits have been landed. Closing PR #16396 and removing active labels.