Bug 259260
| Summary: | Remove 'didChangeScrollOffset' from RenderLayerScrollableArea::scrollTo() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=110673 | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across one revert change of bug 110673.
^ @Simon's reviewed patch landed in above as following: http://trac.webkit.org/changeset/146260
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=148242
WebKit's Source https://github.com/WebKit/WebKit/blob/638ac8184b3860aafc3d68fec13300730af06a6d/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#L424
_______
It was revert because of following:
"This is simply wrong. Something scrolled != the frame scrolled.
Actually RenderLayer can be anything but the frame."
_______
I reverted it locally and it compiles. (Not run 'run-webkit-tests' because I have other scrolling patches as well).
_________
So I just wanted to raise and get input, whether we can remove it as well.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
We can't just remove this. It's a signal that's propagated out to the UI process in WebKit2 (thought I'm not sure what responds to it).
Ahmad Saleem
Marking Invalid based on Simon's comment.