Bug 259286

Summary:

REGRESSION(265525@main): wpt /svg/text/scripted/getstartpositionofchar-dominant-baseline.html

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ahmad.saleem792, heycam, ntim, sabouhallawa, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=139258

Attachments:

Description	Flags
test	none

Description Sam Sneddon [:gsnedders] 2023-07-17 12:11:00 PDT

c.f. https://wpt.fyi/results/svg/text/scripted/getstartpositionofchar-dominant-baseline.html?run_id=5186421294366720&run_id=5159272738979840&run_id=5100859438923776&run_id=5131751863615488&run_id=5163365977030656 which regressed in STP 174

bisecting this points at 265525@main, from bug 139258

The test seems to be specifically testing that certain things don't depend on dominant-baseline; it may just be that this a bad test (previously bogusly passing because it relied on dominant-baseline being inherited), but it is nevertheless a test regression.

Comment 1 Radar WebKit Bug Importer 2023-07-17 12:11:11 PDT

<rdar://problem/112420119>

Comment 2 Ahmad Saleem 2023-07-17 14:32:47 PDT

Thanks @Sam, let me explore what is causing this failure, might not be immediate solution from my side but still will look into it.

Comment 3 Cameron McCormack (:heycam) 2023-07-18 21:28:15 PDT

So while this is indeed a test new failure due to making dominant-baseline inherited, it doesn’t reveal a new bug in our SVG text layout code. Manually inheriting the property shows the same issue.

Comment 4 Cameron McCormack (:heycam) 2023-07-18 21:28:28 PDT

Created attachment 467071 [details]
test

Comment 5 Cameron McCormack (:heycam) 2023-07-18 21:31:00 PDT

Using these baseline properties with SVG text isn't super common, but I have seen people use it.  There is a small risk of breaking content, without fixing the underlying SVG text layout problem.

I think we should revert bug 139258 until we can fix the SVG text issue.

Comment 6 Ahmad Saleem 2023-07-19 03:31:47 PDT

I am OK to revert this but at the same time, this change progressed two WPT tests (if I am not wrong) and helped us close three ancient bugs, we had.

Comment 7 Tim Nguyen (:ntim) 2023-07-19 07:07:16 PDT

Fixed by revert: https://webkit.org/b/259335

> I am OK to revert this but at the same time, this change progressed two WPT tests (if I am not wrong) and helped us close three ancient bugs, we had.

I think we do want to try to fix this test if we were to reland this.