Bug 259310

Summary:

AX: VoiceOver only reading "link" for some lines when navigating via arrow up and down in contenteditables.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Andres Gonzalez 2023-07-18 10:15:51 PDT

<div contenteditable id="editable">First line.<br>Some text <a href="#">click me</a> <span>more</span> text.<br><i>Another line.</i></div>

Comment 1 Radar WebKit Bug Importer 2023-07-18 10:16:10 PDT

<rdar://problem/112478167>

Comment 2 Andres Gonzalez 2023-07-18 10:17:29 PDT

rdar://112157851

Comment 3 Andres Gonzalez 2023-07-18 10:33:33 PDT

Created attachment 467069 [details]
Patch

Comment 4 Tyler Wilcock 2023-07-18 10:44:05 PDT

Comment on attachment 467069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467069&action=review

> Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:191
>      auto attributedText = propertyValue<RetainPtr<NSAttributedString>>(AXPropertyName::AttributedText);

Might be a micro-optimization not worth doing, but I don't think we need to attempt to retrieve AXPropertyName::AttributedText from the map if !isConfined.

Comment 5 EWS 2023-07-18 14:23:01 PDT

Committed 266138@main (e9f264d34343): <https://commits.webkit.org/266138@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467069 [details].