Bug 259426

Summary:	Rename isBlobURLContainsNullOrigin to isBlobURLContainingNullOrigin
Product:	WebKit	Reporter:	Anne van Kesteren <annevk>
Component:	DOM	Assignee:	Anne van Kesteren <annevk>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ahmad.saleem792, commit-queue, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=259476
Bug Depends on:	257262, 259474
Bug Blocks:

Description Anne van Kesteren 2023-07-23 05:03:07 PDT

As suggested in https://github.com/WebKit/WebKit/pull/14293#discussion_r1264235936.

Comment 1 Radar WebKit Bug Importer 2023-07-23 05:03:18 PDT

<rdar://problem/112731483>

Comment 2 Anne van Kesteren 2023-07-24 09:04:38 PDT

Pull request: https://github.com/WebKit/WebKit/pull/16040

Comment 3 EWS 2023-07-24 11:37:20 PDT

Committed 266258@main (2b1106bf431a): <https://commits.webkit.org/266258@main>

Reviewed commits have been landed. Closing PR #16040 and removing active labels.

Comment 4 WebKit Commit Bot 2023-07-25 03:33:54 PDT

Re-opened since this is blocked by bug 259474

Comment 5 Ahmad Saleem 2023-07-25 05:42:24 PDT

@Anne - I tried to revert the revert patch but I think Webkit bot is failing and this might need to be done again but I think you can change 'Reviewed by NOBODY' line with:

Reviewed by Tim Nguyen.

and then do 'unsafe-merge-queue'.

It will eliminate another review for Tim.


@Akash - if you have any reason on why the WebKitBot is not able to do revert of 'revert', would appreciate your help and your an see logs of my tries in WebKitBot channel on Slack.

Comment 6 Aakash Jain 2023-07-25 08:39:47 PDT

It was re-landed in https://bugs.webkit.org/show_bug.cgi?id=259476