Bug 259524

Summary:	REGRESSION(266293@main): media/audioSession/audioSessionState.html is a flaky failure
Product:	WebKit	Reporter:	Ben Schwartz <ben_schwartz>
Component:	New Bugs	Assignee:	youenn fablet <youennf>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=259368 https://bugs.webkit.org/show_bug.cgi?id=261957 https://bugs.webkit.org/show_bug.cgi?id=263479

Description Ben Schwartz 2023-07-26 10:52:00 PDT

http/tests/media/hls/track-in-band-multiple-cues.html

This test is a flaky failure on all tested platforms.

HISTORY:

https://results.webkit.org/?suite=layout-tests&test=media%2FaudioSession%2FaudioSessionState.html

TEXT DIFF:

-PASS AudioSession and interruption
+FAIL AudioSession and interruption promise_test: Unhandled rejection with value: "no audio session state change"

DIFF URL:

https://ews-build.s3-us-west-2.amazonaws.com/iOS-16-Simulator-WK2-Tests-EWS/68afe987-14290/media/audioSession/audioSessionState-pretty-diff.html

REPRODUCIBILITY:

I was able to reproduce this bug on the iOS 16 Simulator running the test as follows:

run-webkit-tests --ios-simulator --iterations 50 --verbose http/tests/media/hls/track-in-band-multiple-cues.html

REGRESSION:

I was able to bisect a regression point via local testing and the flakiness dashboard. This test reproduced at 266293@main, but it did not reproduce at 266292@main. Changes at 266293@main appear to be directly related to this error, and is likely what caused the failure.

Comment 1 Radar WebKit Bug Importer 2023-07-26 10:52:14 PDT

<rdar://problem/112914519>

Comment 2 Ben Schwartz 2023-07-26 11:15:17 PDT

I have marked this test as a flaky failure while this issue is investigated. (Link: https://github.com/WebKit/WebKit/pull/16104)

Comment 3 Ben Schwartz 2023-07-26 12:24:37 PDT

Corrected erroneous title. Bug is actually with this test: media/audioSession/audioSessionState.html

Comment 4 Ben Schwartz 2023-07-26 18:57:28 PDT

(In reply to Ben Schwartz from comment #2)
> I have marked this test as a flaky failure while this issue is investigated.
> (Link: https://github.com/WebKit/WebKit/pull/16104)

New PR link: https://github.com/WebKit/WebKit/pull/16125

Comment 5 EWS 2023-07-26 20:29:49 PDT

Test gardening commit 266350@main (42c22e4de21f): <https://commits.webkit.org/266350@main>

Reviewed commits have been landed. Closing PR #16125 and removing active labels.

Comment 6 youenn fablet 2023-09-06 08:35:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17483

Comment 7 EWS 2023-09-06 11:18:26 PDT

Committed 267683@main (cfee0fec20b6): <https://commits.webkit.org/267683@main>

Reviewed commits have been landed. Closing PR #17483 and removing active labels.

Comment 8 Jonathan Bedard 2023-09-14 07:45:18 PDT

Suspect that this change has now made a different test flakey:
https://results.webkit.org/?suite=layout-tests&test=media%2Faudio-play-with-video-element-interrupted.html