Bug 259528
| Summary: | REGRESSION(266045@main?): [ macOS WK2 ] fast/attachment/mac/wide-attachment-image-controls-basic.html is a flaky failure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | New Bugs | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | g_squelart, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=259183 | ||
| Bug Depends on: | 259094 | ||
| Bug Blocks: | |||
Ben Schwartz
fast/attachment/mac/wide-attachment-image-controls-basic.html
This test is a flaky failure on macOS Monterey and above.
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fmac%2Fwide-attachment-image-controls-basic.html
TEXT DIFF:
RenderBody {BODY} at (8,8) size 784x82
RenderAttachment {ATTACHMENT} at (1,1) size 266x80
RenderFlexibleBox {DIV} at (0,0) size 266x80 [bgcolor=#0000000D]
- RenderGrid {DIV} at (14,14) size 0x52
- RenderImage {IMG} at (0,26) size 0x0
- RenderFlexibleBox {DIV} at (32,0) size 210x80
- RenderGrid {DIV} at (0,40) size 210x0
- RenderText {#text} at (268,26) size 4x18
- text run at (268,26) width 4: " "
- RenderImage {IMG} at (272,20) size 20x20
+ RenderGrid {DIV} at (14,14) size 52x52
+ RenderImage {IMG} at (0,0) size 52x52
+ RenderFlexibleBox {DIV} at (84,0) size 158x80
+ RenderGrid {DIV} at (0,40) size 158x0
+ RenderText {#text} at (268,52) size 4x18
+ text run at (268,52) width 4: " "
+ RenderImage {IMG} at (272,46) size 20x20
RenderText {#text} at (0,0) size 0x0
layer at (9,9) size 266x80
RenderBlock (relative positioned) {DIV} at (0,0) size 266x80 [color=#00000000]
DIFF URL:
https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK2-Tests/266314@main%20(4170)/fast/attachment/mac/wide-attachment-image-controls-basic-pretty-diff.html
REPRODUCIBILITY:
I was able to reproduce this bug on macOS Ventura Release ToT running the test as follows:
run-webkit-tests --iterations 500 --verbose fast/attachment/mac/wide-attachment-image-controls-basic.html
REGRESSION:
I was able to bisect a regression point via local testing and the flakiness dashboard. This test reproduced at 266045@main, but it did not reproduce at 266044@main. Changes at 266045@main appear to be related to this error, but more investigation is needed to determine for sure.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/112918166>
Ben Schwartz
I have marked this test as a flaky failure while this issue is investigated. (Link: https://github.com/WebKit/WebKit/pull/16107)
EWS
Test gardening commit 266321@main (6b6e228f29e0): <https://commits.webkit.org/266321@main>
Reviewed commits have been landed. Closing PR #16107 and removing active labels.
Gerald Squelart
At first glance, looking at the history of this failure, it seems to start at https://commits.webkit.org/266038@main https://bugs.webkit.org/show_bug.cgi?id=259094
That patch changed the IMG size to 0x52, and the flaky "failure" goes back to a more expected 52x52.
To be continued...
Ben Schwartz
Upon further inspection, it appears that this issue occurs only on WK2. Amending previous gardening commit to reflect the correct expectation.
HISTORY:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fattachment%2Fmac%2Fwide-attachment-image-controls-basic.html&flavor=wk2
I have marked this test as a flaky failure on macOS WK2 while this issue is investigated. (Link: https://github.com/WebKit/WebKit/pull/16107)
EWS
Test gardening commit 266477@main (20e7648a111f): <https://commits.webkit.org/266477@main>
Reviewed commits have been landed. Closing PR #16248 and removing active labels.
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/22255
EWS
Committed 272548@main (44fccba78690): <https://commits.webkit.org/272548@main>
Reviewed commits have been landed. Closing PR #22255 and removing active labels.
EWS
Committed 272938@main (6eee6a333d53): <https://commits.webkit.org/272938@main>
Reviewed commits have been landed. Closing PR #22677 and removing active labels.
EWS
Test gardening commit 272944@main (069950e20dd5): <https://commits.webkit.org/272944@main>
Reviewed commits have been landed. Closing PR #22685 and removing active labels.