Bug 259581
| Summary: | Implement automatic text track selection for 'metadata' tracks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://wpt.live/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata.html | ||
Ahmad Saleem
Hi Team,
Going through WPT failures, came across following WPT test case failing:
Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=189185
WPT: https://wpt.fyi/results/html/semantics/embedded-content/media-elements/track/track-element/track-selection-metadata.html?label=experimental&label=master&aligned=
Just raising so we can fix and align with spec.
_____
This below compiles and progresses following test:
void HTMLMediaElement::configureMetadataTextTrackGroup(const TrackGroup& group)
{
ASSERT(group.tracks.size());
// https://html.spec.whatwg.org/multipage/embedded-content.html#honor-user-preferences-for-automatic-text-track-selection
// 3. If there are any text tracks in the media element's list of text tracks whose text track kind is
// chapters or metadata that correspond to track elements with a default attribute set
// whose text track mode is set to disabled, then set the text track mode of all such tracks to hidden.
for (auto& textTrack : group.tracks) {
if (textTrack->mode() != TextTrack::Mode::Disabled)
continue;
if (!textTrack->isDefault())
continue;
textTrack->setMode(TextTrack::Mode::Hidden);
}
}
_______
Just wanted to raise so we can fix it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113004825>
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/16154
EWS
Committed 266380@main (ec1a4f3966b2): <https://commits.webkit.org/266380@main>
Reviewed commits have been landed. Closing PR #16154 and removing active labels.