Bug 259631

Summary: Out-of-flow <br> should not trigger a line break
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kangil.han, koivisto, kondapallykalyan, mmaxfield, ntim, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230048
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Attachments
Patch (14.79 KB, patch)
2023-07-29 16:24 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (23.60 KB, patch)
2023-07-29 21:40 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.19 KB, patch)
2023-07-30 21:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-07-29 16:24:02 PDT
Created attachment 467157 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2023-07-29 21:32:20 PDT
Comment on attachment 467157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=467157&action=review > LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1 > +<style> Would be a really good WPT especially if browsers disagree here.
alan
Comment 3 2023-07-29 21:40:22 PDT
Created attachment 467158 [details] Patch
alan
Comment 4 2023-07-30 21:09:11 PDT
Created attachment 467159 [details] Patch
alan
Comment 5 2023-08-01 07:28:58 PDT
alternatively we could just create a generic RenderBox for such out-of-flow line breaks so that we don't have to promote RenderLineBreak to a RenderBox subclass.
alan
Comment 6 2023-08-01 07:29:36 PDT
(though most of this patch would still be needed)
alan
Comment 7 2023-08-01 07:31:08 PDT
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 467157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=467157&action=review > > > LayoutTests/fast/inline/out-of-flow-forced-line-break.html:1 > > +<style> > > Would be a really good WPT especially if browsers disagree here. agree. we would still fail slightly more involved WPT tests though.
EWS
Comment 8 2023-08-01 08:23:20 PDT
Committed 266475@main (f71ea9e98639): <https://commits.webkit.org/266475@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 467159 [details].
Radar WebKit Bug Importer
Comment 9 2023-08-01 08:24:19 PDT
<rdar://problem/113208050>
Note You need to log in before you can comment on or make changes to this bug.