Bug 259639

Summary:	[Win][MiniBrowser] A download dialog is displayed even though the content is not for download since 266320@main
Product:	WebKit	Reporter:	Kenji Shukuwa <kenji.shukuwa>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Kenji Shukuwa 2023-07-30 18:48:30 PDT

On some pages, a download dialog is displayed even though the content is not for download since 266320@main.

https://dailyportalz.jp/kiji/company-made-marble-gum-and-felix-gum
https://www.sankei.com/article/20230727-OFGQO3XS5VNJPBTXAOACX2UQDA/
https://game.watch.impress.co.jp/docs/news/1519363.html
https://gadget.phileweb.com/post-47994/
https://www.cnn.co.jp/showbiz/35207101.html

Comment 1 Kenji Shukuwa 2023-07-30 18:52:03 PDT

The content that displayed the download dialog did not have a Content-Type header.
Therefore the MIME type is empty.

Comment 2 Kenji Shukuwa 2023-07-30 18:58:17 PDT

The SOUP port does not seem to download subframe content.


https://github.com/WebKit/WebKit/blob/e50b54c0585e5846b51d94711b75515282bc3bd8/Tools/MiniBrowser/gtk/BrowserTab.c#L129-L130
---
    if (!webkit_response_policy_decision_is_main_frame_main_resource(responseDecision))
        return FALSE;
---

Comment 3 Kenji Shukuwa 2023-07-30 19:45:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/16223

Comment 4 EWS 2023-08-01 05:13:15 PDT

Committed 266471@main (b6570992dff1): <https://commits.webkit.org/266471@main>

Reviewed commits have been landed. Closing PR #16223 and removing active labels.

Comment 5 Radar WebKit Bug Importer 2023-08-01 05:14:20 PDT

<rdar://problem/113200343>