Bug 259753
| Summary: | [git-webkit] setup ends up hardcoding worktree path in hooks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | emw, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
`git-webkit setup` ends up inserting a line such as:
```
LOCATION = r'/Volumes/gsnedders/projects/Safari/OS2/Tools/Scripts/hooks/prepare-commit-msg'
```
However, in my case, this has ended up with a path within a worktree hardcoded in the hook. This… stopped working when I pruned the worktree.
We should, at most, hardcode the path from the top-level directory of the working tree, and then just use the current working tree.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113294324>
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/16332
EWS
Committed 266577@main (3aa38b6cb9f2): <https://commits.webkit.org/266577@main>
Reviewed commits have been landed. Closing PR #16332 and removing active labels.