Bug 259835
| Summary: | Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
dewei_zhu
Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server.
Moving to python3 http.server would have following benefits:
1. Remove the dependency of Twisted, which could be an issue for some users local environment.
2. Speedup the first run for run-benchmark, which installs twisted if no local installation
The reason the initial version does not use python2 built-in http server is because sometimes the http server fails to server the content.
We should ensure python3 version does not have this issue.
Furthermore, we also need to make sure the benchmark score does not change by switching between different http servers.
Base on above, it seems reasonable to implement http.server version separately and use a flag to switch to http.server.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/113766369>
james
Pull request: https://github.com/WebKit/WebKit/pull/16900
EWS
Committed 271176@main (1e3555d85962): <https://commits.webkit.org/271176@main>
Reviewed commits have been landed. Closing PR #16900 and removing active labels.