Bug 259835

Summary:	Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server
Product:	WebKit	Reporter:	dewei_zhu
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description dewei_zhu 2023-08-04 12:51:09 PDT

Investigate the possibility of replacing twisted http server in run-benchmark with python3 http.server.
Moving to python3 http.server would have following benefits:
1. Remove the dependency of Twisted, which could be an issue for some users local environment.
2. Speedup the first run for run-benchmark, which installs twisted if no local installation

The reason the initial version does not use python2 built-in http server is because sometimes the http server fails to server the content.
We should ensure python3 version does not have this issue.
Furthermore, we also need to make sure the benchmark score does not change by switching between different http servers.
Base on above, it seems reasonable to implement http.server version separately and use a flag to switch to http.server.

Comment 1 Radar WebKit Bug Importer 2023-08-11 12:52:12 PDT

<rdar://problem/113766369>

Comment 2 james 2023-08-21 14:11:26 PDT

Pull request: https://github.com/WebKit/WebKit/pull/16900

Comment 3 EWS 2023-11-27 15:46:28 PST

Committed 271176@main (1e3555d85962): <https://commits.webkit.org/271176@main>

Reviewed commits have been landed. Closing PR #16900 and removing active labels.