| Summary: | [css-nesting] CSSStyleRule should inherit from CSSGroupingRule | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | ahmad.saleem792, m_dubet, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Tim Nguyen (:ntim)
2023-08-04 22:29:16 PDT
Fun fact, I had anticipated this change in the spec back in March but never got it merged https://github.com/WebKit/WebKit/pull/11835 (In reply to Matthieu Dubet from comment #2) > https://github.com/WebKit/WebKit/pull/9332/files#diff- > 42726ca1f6c0499ccb16f1be2a209fc147a4f01139c7de9b9ad51aab94ea8231R37 Now that it matches the IDL, it's probably more acceptable. I think we still missing one change and failing following sub-test here: WPT Test: http://wpt.live/css/css-nesting/cssom.html ___ CSSStyleRule is a CSSGroupingRule We get: assert_equals: expected function "function CSSGroupingRule() { [native code] }" but got function "function CSSRule() { [native code] }" @http://wpt.live/css/css-nesting/cssom.html:12:18 @http://wpt.live/resources/testharness.js:2599:30 test@http://wpt.live/resources/testharness.js:628:34 global code@http://wpt.live/css/css-nesting/cssom.html:11:7 ___ Or we should close this and have separate? No indeed, this has never been merged so still need to be fixed (changing the IDL is easy, but it need a refactoring of the StyleRuleBase/StyleRuleGroup/StyleRuleWithNesting classes) |