Bug 259900

Summary: [IFC] Add fast path for simple text only content
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, koivisto, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2023-08-07 14:37:54 PDT 
ssia
Comment 1 zalan 2023-08-07 16:37:58 PDT 
Created attachment 467215 [details]
Patch
Comment 2 zalan 2023-08-07 19:34:41 PDT 
Created attachment 467216 [details]
Patch
Comment 3 zalan 2023-08-07 20:00:47 PDT 
Created attachment 467217 [details]
Patch
Comment 4 zalan 2023-08-08 11:21:31 PDT 
Created attachment 467223 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2023-08-08 14:20:09 PDT 
<rdar://problem/113585987>
Comment 6 zalan 2023-08-08 17:17:17 PDT 
Created attachment 467226 [details]
Patch
Comment 7 Antti Koivisto 2023-08-10 08:10:23 PDT 
Comment on attachment 467226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467226&action=review

Very cool. SLL is back!

> Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h:101
> +class AbstractLineBuilder {
> +public:
> +    virtual LineLayoutResult layoutInlineContent(const LineInput&, const std::optional<PreviousLine>&) = 0;
> +    virtual ~AbstractLineBuilder() { };
> +};

Maybe we could use a template instead of this at some point.
Comment 8 zalan 2023-08-10 09:17:35 PDT 
Created attachment 467237 [details]
Patch
Comment 9 zalan 2023-08-11 05:56:52 PDT 
Created attachment 467244 [details]
Patch
Comment 10 zalan 2023-08-11 06:02:31 PDT 
Created attachment 467245 [details]
Patch
Comment 11 EWS 2023-08-11 07:07:37 PDT 
Committed 266815@main (ba2673dfb458): <https://commits.webkit.org/266815@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467245 [details].