Bug 259952

Summary:

AX: Initialize the AX thread on first client request.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andres Gonzalez 2023-08-08 16:09:16 PDT

Comment 1 Radar WebKit Bug Importer 2023-08-08 16:09:27 PDT

<rdar://problem/113592230>

Comment 2 Andres Gonzalez 2023-08-08 16:24:21 PDT

Created attachment 467225 [details]
Patch

Comment 3 Tyler Wilcock 2023-08-08 16:58:56 PDT

Comment on attachment 467225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467225&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:719
> +    if (LIKELY(!isMainThread() || axThreadInitialized))

The latter check (axThreadInitialized) is cheaper, so maybe it should come first?

if (LIKELY(axThreadInitialized || !isMainThread()))

Comment 4 Andres Gonzalez 2023-08-09 10:01:23 PDT

Created attachment 467231 [details]
Patch

Comment 5 EWS 2023-08-09 11:25:23 PDT

Committed 266735@main (fbca8d9e20b9): <https://commits.webkit.org/266735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 467231 [details].