Bug 260013

Summary: [Win] WebCore::instanceHandle() always returns a null HINSTANCE
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Fujii Hironori
Reported 2023-08-09 23:00:34 PDT
[Win] WebCore::instanceHandle() always returns a null HINSTANCE WebCore::setInstanceHandle is called from nowhere in Win WK2. WebCore::instanceHandle() is called in the following callsites. WebCore/platform/graphics/win/FullScreenWindow.cpp WebCore/platform/win/MainThreadSharedTimerWin.cpp WebCore/platform/win/PasteboardWin.cpp WebCore/platform/win/WebCoreBundleWin.cpp WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp WebKit/UIProcess/win/WebView.cpp
Attachments
Fujii Hironori
Comment 1 2023-08-09 23:01:25 PDT
What is the HINSTANCE passed to CreateWindow and RegisterClass used for? - The Old New Thing https://devblogs.microsoft.com/oldnewthing/20050418-59/?p=35873
Fujii Hironori
Comment 2 2023-08-09 23:24:15 PDT
EWS
Comment 3 2023-08-10 11:00:31 PDT
Committed 266769@main (a7bd570e6391): <https://commits.webkit.org/266769@main> Reviewed commits have been landed. Closing PR #16558 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2023-08-10 11:01:20 PDT
Note You need to log in before you can comment on or make changes to this bug.